RFC 7639 ALPN #731
Open
arturobernalg wants to merge 1 commit into
Open
Conversation
arturobernalg
force-pushed
the
rfc7639
branch
2 times, most recently
from
42fd028 to
6140646
Compare
arturobernalg
force-pushed
the
rfc7639
branch
from
4b95aca to
8f872b6
Compare
arturobernalg
force-pushed
the
rfc7639
branch
from
aea3fa3 to
5fa9a19
Compare
arturobernalg
force-pushed
the
rfc7639
branch
from
5fa9a19 to
16b5442
Compare
Member
|
@arturobernalg Could you please rebase this change-set? |
arturobernalg
force-pushed
the
rfc7639
branch
2 times, most recently
from
cc58cd1 to
208b565
Compare
Member
Author
@ok2c done. |
arturobernalg
force-pushed
the
rfc7639
branch
from
208b565 to
eed86b1
Compare
ok2c
reviewed
Jan 11, 2026
ok2c
reviewed
Jan 11, 2026
ok2c
reviewed
Jan 11, 2026
arturobernalg
force-pushed
the
rfc7639
branch
from
733a98c to
a910585
Compare
ok2c
reviewed
Jan 11, 2026
arturobernalg
force-pushed
the
rfc7639
branch
2 times, most recently
from
a178fe7 to
e343841
Compare
ok2c
reviewed
Jan 12, 2026
arturobernalg
force-pushed
the
rfc7639
branch
2 times, most recently
from
249924c to
bfb72b3
Compare
arturobernalg
force-pushed
the
rfc7639
branch
from
bfb72b3 to
f5f17fd
Compare
ok2c
reviewed
Apr 3, 2026
| * @return this builder | ||
| * @since 5.6 | ||
| */ | ||
| public HttpAsyncClientBuilder setConnectAlpn(final String... ids) { |
Member
There was a problem hiding this comment.
@arturobernalg What should happen if the caller passes h3, http/0.75, srtuff to this method?
Why do we even need this method at all? There is already HttpVersionPolicy settable on a per route basis and this is exactly what you should be using should you decide to proceed further with this feature.
Member
|
@arturobernalg This change can still make it into |
Encode protocol IDs with core's PercentCodec.HTTP_TOKEN (canonical RFC 7230 tchar form, uppercase hex) and decode strictly, rejecting malformed percent-encoding with ProtocolException. Configure via ConnectAlpnProvider through setConnectAlpnProvider on the classic and async builders; ConnectExec/AsyncConnectExec emit the header when a provider is set.
Member
Author
@ok2c please do another pass |
ok2c
reviewed
Jul 4, 2026
| * @return list of protocol IDs (e.g., {@code "h2"}, {@code "http/1.1"}); | ||
| * {@code null} or empty to omit the header | ||
| */ | ||
| List<String> getAlpnForTunnel(HttpHost target, HttpRoute route); |
Member
There was a problem hiding this comment.
@arturobernalg Same question that I already asked you before. What do you think should happen if this provider returns something other than h2 or http/1.1 from supported ApplicationProtocol enum? Why do we need this interface at all?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ConnectAlpnProvider and inject ALPN header in ConnectExec/AsyncConnectExec. Provide builder hooks for fixed list or provider-driven values.